Re: [HACKERS] Bug in to_timestamp().
Artur Zakirov <a.zakirov@postgrespro.ru>
From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, amul sul <sulamul@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, Alex Ignatov <a.ignatov@postgrespro.ru>, Bruce Momjian <bruce@momjian.us>, amul sul <sul_amul@yahoo.co.in>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-02-06T09:17:17Z
Lists: pgsql-hackers
On Fri, Feb 02, 2018 at 09:54:45PM +0100, Dmitry Dolgov wrote: > For some reason I can't apply it clean to the latest master: > > (Stripping trailing CRs from patch; use --binary to disable.) > patching file doc/src/sgml/func.sgml > (Stripping trailing CRs from patch; use --binary to disable.) > patching file src/backend/utils/adt/formatting.c > (Stripping trailing CRs from patch; use --binary to disable.) > patching file src/test/regress/expected/horology.out > Hunk #1 FAILED at 2769. > Hunk #2 FAILED at 2789. > Hunk #3 succeeded at 2810 with fuzz 2. > Hunk #4 succeeded at 2981 with fuzz 2. > Hunk #5 succeeded at 3011 with fuzz 2. > Hunk #6 FAILED at 3029. > 3 out of 6 hunks FAILED -- saving rejects to file > src/test/regress/expected/horology.out.rej > (Stripping trailing CRs from patch; use --binary to disable.) > patching file src/test/regress/sql/horology.sql It is strange. I still can apply both v9 [1] and v10 [2] via 'git apply'. And Patch Tester [3] says that it is applied. But maybe it is because of my git (git version 2.16.1). You can try also 'patch -p1': $ patch -p1 < 0001-to-timestamp-format-checking-v10.patch 1 - https://www.postgresql.org/message-id/20180112125848.GA32559@zakirov.localdomain 2 - https://www.postgresql.org/message-id/20180201102449.GA29082@zakirov.localdomain 3 - http://commitfest.cputube.org/ -- Arthur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company
Commits
-
Improve behavior of to_timestamp()/to_date() functions
- cf984672427e 12.0 landed
-
Implement TZH and TZM timestamp format patterns
- 11b623dd0a2c 11.0 cited
-
as attache of this mail is patch (to the main tree) with to_char's
- b866d2e2d794 7.1.1 cited