Horton

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

Michael Paquier <michael.paquier@gmail.com>

View thread View on postgr.es
From: Michael Paquier <michael.paquier@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Robert Haas <robertmhaas@gmail.com>, Stephen Frost <sfrost@snowman.net>, Heikki Linnakangas <hlinnaka@iki.fi>, Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-02-01T00:56:37Z
Lists: pgsql-hackers 
On Fri, Jan 26, 2018 at 05:58:48PM -0500, Tom Lane wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
>> Oversight, completely missed that one.
> 
> It looks like no core code uses that macro, so it's got no effect
> unless some third-party code does ... but I changed it anyway.

Good point.  I missed this one as well.  I have double-checked the core
code and it seems to me that we are clear now.
--
Michael

Commits

  1. Avoid unnecessary use of pg_strcasecmp for already-downcased identifiers.