Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

Michael Paquier <michael.paquier@gmail.com>

From: Michael Paquier <michael.paquier@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-01-26T23:51:09Z
Lists: pgsql-hackers
On Fri, Jan 26, 2018 at 12:30:12PM -0500, Tom Lane wrote:
> And done.  I failed to resist the temptation to rename
> compute_attributes_sql_style, since the "sql_style" bit no longer
> conveys anything.  I'd always found compute_attributes_with_style
> to be confusingly named --- seemed like it should have a sibling
> compute_attributes_gracelessly, or something like that.

Nice, thanks for the commit and review!
--
Michael

Commits

  1. Remove the obsolete WITH clause of CREATE FUNCTION.

  2. Extend syntax of CREATE FUNCTION to resemble SQL99.