Horton

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

Michael Paquier <michael.paquier@gmail.com>

View thread View on postgr.es
From: Michael Paquier <michael.paquier@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, Heikki Linnakangas <hlinnaka@iki.fi>, Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-01-24T10:10:40Z
Lists: pgsql-hackers 
On Wed, Jan 24, 2018 at 09:47:50AM +0100, Daniel Gustafsson wrote:
> Attached is a rebased v7 patch which has your amendments (minus
> propname) which passes make check without errors.

Confirmed. I am switching the status as ready for committer for
volatility-v7.patch then.

> The volatility patch is also rebased included, but there the
> discussion whether to keep or drop the deprecated syntax first needs
> to happen (started in your 20180115022748.GB1724@paquier.xyz mail).

Yes, let's see what happens later for this thread.
--
Michael

Commits

  1. Avoid unnecessary use of pg_strcasecmp for already-downcased identifiers.