Horton

Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

Michael Paquier <michael.paquier@gmail.com>

View thread View on postgr.es
From: Michael Paquier <michael.paquier@gmail.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Aleksander Alekseev <a.alekseev@postgrespro.ru>, Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-01-12T02:01:59Z
Lists: pgsql-hackers

Attachments

On Fri, Jan 12, 2018 at 01:45:19PM +1300, Thomas Munro wrote:
> FYI:
> 
> func.sgml:17550: parser error : Opening and ending tag mismatch:
> literal line 17550 and unparseable
>    <literal>NULL</> values for undefined objects.
>                    ^
> func.sgml:17567: parser error : Opening and ending tag mismatch:
> literal line 17567 and unparseable
>    with <literal>NULL</> values.
>                         ^
> func.sgml:17582: parser error : Opening and ending tag mismatch:
> literal line 17582 and unparseable
>    Undefined objects are identified with <literal>NULL</> values.
>                                                          ^
> func.sgml:20721: parser error : chunk is not well balanced
> postgres.sgml:105: parser error : Failure to process entity func
>   &func;
>         ^
> postgres.sgml:105: parser error : Entity 'func' not defined
>   &func;
>         ^

Thanks Mr. Robot and Thomas for the reminder. Attached is an updated
patch set taking care of those warnings, 0002 and 0004 being impacted.
--
Michael

Commits

  1. Eliminate cache lookup errors in SQL functions for object addresses

  2. Refactor routines for name lookups of procedures and operators

  3. Add new flag to format_type_extended() to get NULL for undefined type

  4. Introduce new extended routines for FDW and foreign server lookups

  5. Refactor routines for subscription and publication lookups

  6. get_relid_attribute_name is dead, long live get_attname

  7. Tweak parser so that there is a defined representation for datatypes