Re: IndexTupleDSize macro seems redundant
Stephen Frost <sfrost@snowman.net>
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Ildar Musin <i.musin@postgrespro.ru>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-01-11T20:32:50Z
Lists: pgsql-hackers
Attachments
- remove-indextupledsize-v4.patch (text/x-diff) patch v4
Greetings Tom, Robert, Ildar, all, * Stephen Frost (sfrost@snowman.net) wrote: > That said, since it's not aligned, regardless of the what craziness the > compiler might try to pull, we probably shouldn't go casting it > to something that later hackers might think will be aligned, but we > should add a comment to clarify that it's not aligned and that we can't > act like it is. Updated (combined) patch attached for review. I went through and looked again to make sure there weren't any cases of making an unaligned pointer to a struct and didn't see any, and I added some comments to _bt_restore_page(). Thanks! Stephen
Commits
-
Remove redundant IndexTupleDSize macro.
- d79e7e92bf2a 11.0 landed