Re: Expression based grouping equality implementation

Hi,

On 2017-11-29 00:09:34 -0800, Andres Freund wrote:
> Similar to [1] (Expression based aggregate transition / combine function
> invocation), this patch provides small-medium performance benefits in
> order to later enable larger performance benefits with JIT compilation.

Here's an updated version of the patch.


> - there's now a bit of additional code at callsites to reset the
>   ExprContext - was tempted to put that that in a ExecQualAndReset()
>   inline wrapper, but that's not entirely trivial because executor.h
>   doesn't include memutils.h and ResetExprContext() is declared late.

I've now added ExecQualAndReset(), in patch 0001, and solved the above
problems by including memutils.h and "inlining" ResetExprContext() to
avoid the ordering issue. Not pretty, but seems better than the
alternatives.


I'm not yet quite happy with this, but I thought it'be good to send an
updated version...

- Andres