Horton

Re: Unimpressed with pg_attribute_always_inline

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Thomas Munro <thomas.munro@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-01-09T01:30:10Z
Lists: pgsql-hackers 
Hi,

On 2018-01-08 20:20:09 -0500, Tom Lane wrote:
> No, you have it right.  I checked locally and confirmed Andres' assertion
> that by default, gcc (my version anyway) is not persuaded to inline
> ExecHashJoinImpl simply by "inline", but "always_inline" persuades it.
> Maybe at some level higher than -O2, or with some other weird flag,
> it would do what we want; but we probably don't want to mess with global
> compiler flags for this.

There's -finline-limit=n, but as you say, I don't think we want to mess
with this.

Greetings,

Andres Freund

Commits

  1. Improve implementation of pg_attribute_always_inline.

  2. Add pg_attribute_always_inline.