Re: [HACKERS] Something for the TODO list: deprecating abstime and friends
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Date: 2018-09-28T22:32:40Z
Lists: pgsql-hackers
Attachments
- v1-0001-Remove-timetravel-extension.patch (text/x-diff)
Hi, On 2017-12-13 00:05:06 -0800, Andres Freund wrote: > > * contrib/spi/timetravel depends on abstime columns to represent what > > would nowadays be better done as a tstzrange. I'd have thought we > > could maybe toss that example module overboard, but we just today got > > a question about its usage, so I'm afraid it's not quite dead yet. > > What shall we do with that? > > Looking at the code I'd be pretty strongly inclined to scrap it. > > > Before I'd discovered this thread, I'd started to write up a > patch. Attached. It's clearly not fully done. Questions I'd while > hacking things up: > - what to do with contrib/spi/timetravel - I'd just removed it from the > relevant Makefile for now. > - nabstime.c currently implements timeofday() which imo is a pretty > weird function. I'd be quite inclined to remove it at the same time as > this. Here's a refreshed version of this patch. First patch removes contrib/spi/timetravel, second patch removes abstime, reltime, tinterval together with timeofday(). I think we should just go ahead and commit something like this soon. - Andres
Commits
-
Add static assertions about pg_control fitting into one disk sector.
- 3cb29c42f990 10.0 landed
-
doc: Remove PostgreSQL version number from xml2 deprecation notice
- 3163baa6d2d1 9.3.0 cited