Re: [PATCH] Include application_name in "connection authorized" log message
Stephen Frost <sfrost@snowman.net>
From: Stephen Frost <sfrost@snowman.net>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Don Seiler <don@seiler.us>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2018-09-28T00:26:20Z
Lists: pgsql-hackers
Attachments
- add_appname_to_authmsg_v3.patch (text/x-diff) patch v3
Greetings, all, * Stephen Frost (sfrost@snowman.net) wrote: > I still don't see that as a reason for tools to be suseptible to serious > issues if a funky user gets created and I'd be surprised if there > weren't other ways to get funky characters into the log file, but that's > all ultimately an independent issue from this. I'll add the comments as > discussed and discourage using the clean ascii function, but otherwise > keep things as-is in that regard. Updated patch with lots of comments added around pg_clean_ascii() about why it exists, why we do the cleaning, and warnings to discourage people from using it without good cause. I've also done some additional testing with it and it seems to be working well. I'll poke at it a bit more tomorrow but if there aren't any other concerns, I'll commit it towards the end of the day. Thanks! Stephen
Commits
-
Add application_name to connection authorized msg
- 8bddc864000f 12.0 landed