Horton

Re: Problem while setting the fpw with SIGHUP

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, Robert Haas <robertmhaas@gmail.com>, hlinnaka <hlinnaka@iki.fi>, Dilip Kumar <dilipbalaut@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-09-27T05:04:40Z
Lists: pgsql-hackers 
On Thu, Sep 27, 2018 at 10:03:59AM +0530, Amit Kapila wrote:
> I think, in this case, it might be advisable to just fix the problem
> (a) which is what has been reported originally in the thread and
> AFAICS, the fix for that is clear as compared to the problem (b).  If
> you agree, then we can discuss what is the best fix for the first
> problem (a).

Okay, thanks for the input.  The fix for (a) would be in my opinion to
just move the call to RecoveryInProgress() out of the critical section,
then save the result into a variable, and use the variable within the
critical section to avoid the potential palloc() problems.  What do you
think?
--
Michael

Commits

  1. Fix assertion failure when updating full_page_writes for checkpointer.

  2. Attach FPI to the first record after full_page_writes is turned on.

  3. Revamp the WAL record format.

  4. Move the backup-block logic from XLogInsert to a new file, xloginsert.c.