Re: pgsql: Remove absolete function TupleDescGetSlot().

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-09-26T00:04:14Z
Lists: pgsql-hackers
Hi Andres,

On Tue, Sep 25, 2018 at 11:39:05PM +0000, Andres Freund wrote:
> Remove absolete function TupleDescGetSlot().
> 
> TupleDescGetSlot() was kept around for backward compatibility for
> user-written SRFs. With the TupleTableSlot abstraction work, that code
> will need to be version specific anyway, so there's no point in
> keeping the function around any longer.

There are still references in the code to this function, and a
declaration of it:
git grep TupleDescGetSlot
doc/src/sgml/xfunc.sgml:     * user-defined SRFs that use the deprecated TupleDescGetSlot().
src/include/funcapi.h:   * user-defined SRFs that use the deprecated TupleDescGetSlot().
src/include/funcapi.h: * TupleTableSlot *TupleDescGetSlot(TupleDesc tupdesc) - Builds a
src/include/funcapi.h:extern TupleTableSlot *TupleDescGetSlot(TupleDesc tupdesc);
--
Michael

Commits

  1. Clean up in the wake of TupleDescGetSlot() removal / 10763358c3f.

  2. Remove absolete function TupleDescGetSlot().