Horton

Re: Problem while setting the fpw with SIGHUP

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: amit.kapila16@gmail.com, robertmhaas@gmail.com, hlinnaka@iki.fi, dilipbalaut@gmail.com, pgsql-hackers@postgresql.org
Date: 2018-09-06T23:37:28Z
Lists: pgsql-hackers 
On Tue, Aug 28, 2018 at 07:34:36PM +0900, Kyotaro HORIGUCHI wrote:
> Thanks for prompting. The difference is in a comment and I'm fine
> with the change.

/*
 * Properly accept or ignore signals the postmaster might send us.
 */
-       pqsignal(SIGHUP, StartupProcSigHupHandler); /* reload config file */
+       pqsignal(SIGHUP, SIG_IGN);  /* ignore reload config */

I am finally coming back to this patch set, and that's one of the first
things I am going to help moving on for this CF.  And this bit from the
last patch series is not acceptable as there are some parameters which
are used by the startup process which can be reloaded.  One of them is
wal_retrieve_retry_interval for tuning when fetching WAL at recovery.
--
Michael

Commits

  1. Fix assertion failure when updating full_page_writes for checkpointer.

  2. Attach FPI to the first record after full_page_writes is turned on.

  3. Revamp the WAL record format.

  4. Move the backup-block logic from XLogInsert to a new file, xloginsert.c.