Re: Out arguments name of "pg_identify_object_as_address" function in 9.5.14 and 11beta3

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jean-Pierre Pelletier <jean.pierre.pelletier0@gmail.com>, pgsql-hackers@postgresql.org
Date: 2018-09-05T15:57:11Z
Lists: pgsql-hackers

Attachments

On 2018-Sep-05, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:

> > That said, I haven't heard of anyone using these functions in code yet,
> > so if we change it in 11 or 12 nobody is going to complain.
> 
> ... and that's pretty much my feeling.  It seems really unlikely that
> anyone's using named-argument notation for pg_get_object_address, and
> even if they are, it wouldn't be very painful to change, or just not
> use the notation if they need cross-branch compatibility.  I think it's
> more useful in the long run to make the names consistent.
> 
> Will go take care of it.

Agreed, thanks.  If you haven't touched the docs yet, here's the change
-- 9.5/9.6/10 need a slight adjustment from 11/master.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Make argument names of pg_get_object_address consistent, and fix docs.