Horton

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Victor Wagner <vitus@wagner.pp.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-09-04T20:25:21Z
Lists: pgsql-hackers 
On 2018-09-04 16:13:45 -0400, Tom Lane wrote:
> Victor Wagner <vitus@wagner.pp.ru> writes:
> > Tom Lane <tgl@sss.pgh.pa.us> пишет:
> >> (I was testing PG HEAD, not the 11 branch, but I don't see a reason
> >> to think that'd make a difference.)
> 
> > Alas, it does. First thing I've done after discovering this bug, it is
> > to look if it exists in master. And master passes this test on the same
> > machine where problem was discovered.
> 
> Oh really ... I'll go try again.  Now I agree with Andres, we need
> to understand *exactly* what is failing here rather than guess.
> 
> My first thought was that the C99 changeover might explain the
> difference.  But clang doesn't require any special switch to select
> C99 mode, so in principle that should've made no difference to clang
> builds.

Thomas and I are sitting in a cafe and are trying to figure out what's
going on...

Greetings,

Andres Freund

Commits

  1. Error out for clang on x86-32 without SSE2 support, no -fexcess-precision.

  2. Fix 8a934d677 for libc++ and make more include order resistant.