Horton

Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -r option)

Yugo Nagata <nagata@sraoss.co.jp>

View thread View on postgr.es
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Michael Banck <michael.banck@credativ.de>
Cc: Magnus Hagander <magnus@hagander.net>, Daniel Gustafsson <daniel@yesql.se>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-08-30T09:10:54Z
Lists: pgsql-hackers

Attachments

On Thu, 30 Aug 2018 10:54:08 +0200
Michael Banck <michael.banck@credativ.de> wrote:

> Hi,
> 
> On Thu, Aug 30, 2018 at 05:48:24PM +0900, Yugo Nagata wrote:
> > Oops, It's my mistake. I updated the patch.
> 
> Looks good to me now.
> 
> One could argue that the message could be 'checksums verified in file
> FILE' (plural) rather than 'checksum verified in file FILE', but that is
> quickly approaching bikeshed territory I guess.

It seems to me reasonable. Although I'm not native English speaker, if this
is more natural for Westerners, it is better to fix. 

Attached is the revised version.

Regards,
-- 
Yugo Nagata <nagata@sraoss.co.jp>

Commits

  1. pg_verify_checksums: rename -d to --verbose