Horton

Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -r option)

Yugo Nagata <nagata@sraoss.co.jp>

View thread View on postgr.es
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Michael Banck <michael.banck@credativ.de>
Cc: Magnus Hagander <magnus@hagander.net>, Daniel Gustafsson <daniel@yesql.se>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-08-30T08:35:09Z
Lists: pgsql-hackers

Attachments

On Thu, 30 Aug 2018 10:13:31 +0200
Michael Banck <michael.banck@credativ.de> wrote:

> Hi,
> 
> thanks for fixing this up!
> 
> On Wed, Aug 29, 2018 at 11:25:28PM +0900, Yugo Nagata wrote:
> > diff --git a/doc/src/sgml/ref/pg_verify_checksums.sgml b/doc/src/sgml/ref/pg_verify_checksums.sgml
> > index ecc5501eae..a1ff060c2b 100644
> > --- a/doc/src/sgml/ref/pg_verify_checksums.sgml
> > +++ b/doc/src/sgml/ref/pg_verify_checksums.sgml
> > @@ -64,8 +64,8 @@ PostgreSQL documentation
> >        <term><option>-d</option></term>
> 
> This -d needs to be renamed to -v as well I guess.
> 
> >        <listitem>
> >         <para>
> > -        Enable debug output. Lists all checked blocks and their checksum.
> > -       </para>
> > +        Enable debug output. Lists all checked files.
> 
> I'd say 'Enable verbose output.' would be more appropriate now.
> 
> Looks good to me otherwise.

Thank you for your review. I forgot the doc fix.
Attached is the updated patch.

Regards,
-- 
Yugo Nagata <nagata@sraoss.co.jp>

Commits

  1. pg_verify_checksums: rename -d to --verbose