Re: pg_verify_checksums -r option
Yugo Nagata <nagata@sraoss.co.jp>
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-08-27T10:53:36Z
Lists: pgsql-hackers
On Fri, 24 Aug 2018 18:01:09 +0200 Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > I'm curious about this option: > > -r RELFILENODE check only relation with specified relfilenode > > but there is no facility to specify a database. > > Also, referring to the relfilenode of a mapped relation seems a bit > inaccurate. > > Maybe reframing this in terms of the file name of the file you want > checked would be better? If we specified 1234 to -r option, pg_verify_shceksums checks not only 1234 but also 1234_vm, 1234_fsm, and 1234.1, 1234.2, ... and so on, so I think it makes senses to allow to specify a relfilenode instead of a file name. I think it is reasonable to add a option to specify a database, although I don't know which character is good because both -d and -D are already used.... Regards, -- Yugo Nagata <nagata@sraoss.co.jp>
Commits
-
pg_verify_checksums: rename -d to --verbose
- a846e6d0239d 12.0 landed
- a840a8ac7b8a 11.0 landed