Horton

Re: [PATCH] XLogReadRecord returns pointer to currently read page

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Cc: PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Date: 2018-08-17T03:55:21Z
Lists: pgsql-hackers 
On Fri, Aug 17, 2018 at 08:47:15AM +0500, Andrey Lepikhov wrote:
> Previously, in all cases of using WAL this was not a problem. However if you
> plan to perform some decoding operations before returning the WAL record to
> the caller (this is my case), this can lead to bugs that are difficult to
> catch.

What kind of cases with logical decoding are you referring to?  If 
any of them can be reproduced with upstream, could you send a
reproducer, or a way to see it?
--
Michael

Commits

  1. Improve description of buffer used to store records in WAL reader

  2. Remove unnecessary memcpy when reading WAL record fitting on page