A dubious message related to SP-GiST compress method.
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: pgsql-hackers@lists.postgresql.org
Date: 2018-08-10T01:07:42Z
Lists: pgsql-hackers
Attachments
- spguilts_msg.patch (text/x-patch) patch
I ran across the followin gcode in spgutils.c.
> if (OidIsValid(cache->config.leafType) &&
> cache->config.leafType != atttype)
> {
> if (!OidIsValid(index_getprocid(index, 1, SPGIST_COMPRESS_PROC)))
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("compress method must not defined when leaf type is different from input type")));
> fillTypeDesc(&cache->attLeafType, cache->config.leafType);
IIUC the fourth line looks inconsistent with the message in 7th
line. Compress methos is required in the case. Isn't "must not
defined" a typo of "must be defined"?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Commits
-
Fix typo in SP-GiST error message
- 1b9d1b08fe59 11.0 landed
- 2b13702d5c7e 12.0 landed