Horton

Thread

Commits

  1. Add RECURSIVE to documentation index

  1. Doc patch: add RECURSIVE to bookindex

    Daniel Verite <daniel@manitou-mail.org> — 2018-07-31T11:30:35Z

       Hi,

I've noticed that RECURSIVE as a term is not in the index,
and thought it should be.
PFA a patch to add it with references to WITH queries and CREATE VIEW.

Best regards,
-- 
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

  2. Re: Doc patch: add RECURSIVE to bookindex

    Fabien COELHO <coelho@cri.ensmp.fr> — 2018-07-31T12:41:55Z

    Hello Daniel,

> I've noticed that RECURSIVE as a term is not in the index, and thought 
> it should be. PFA a patch to add it with references to WITH queries and 
> CREATE VIEW.

Sounds reasonable.

Why referencing only create_view, but not delete, insert, update, select 
or select_into where RECURSIVE is also used?

ISTM that at least the select page should be referenced, I'm less sure of 
the others because there it appears only in the synopsys.

-- 
Fabien.

  3. Re: Doc patch: add RECURSIVE to bookindex

    Daniel Verite <daniel@manitou-mail.org> — 2018-07-31T14:17:58Z

    	Fabien COELHO wrote:

> Why referencing only create_view, but not delete, insert, update, select 
> or select_into where RECURSIVE is also used?
> 
> ISTM that at least the select page should be referenced, I'm less sure of 
> the others because there it appears only in the synopsys.

Looking at other occurrences of <indexterm>, it seems
they're used quite sparingly, limiting the references to only
the pages that have the most relevant explanation for the term,
as opposed to trying to be exhaustive.

For instance, select.sgml has only three <indexterm>, and
the entries for WHERE or JOIN don't even refer to it.
ISTM that it's on purpose, to keep the index lean, and it works.


Best regards,
-- 
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

  4. Re: Doc patch: add RECURSIVE to bookindex

    Fabien COELHO <coelho@cri.ensmp.fr> — 2018-07-31T19:11:50Z

    >> Why referencing only create_view, but not delete, insert, update, select
>> or select_into where RECURSIVE is also used?
>>
>> ISTM that at least the select page should be referenced, I'm less sure of
>> the others because there it appears only in the synopsys.
>
> Looking at other occurrences of <indexterm>, it seems
> they're used quite sparingly, limiting the references to only
> the pages that have the most relevant explanation for the term,
> as opposed to trying to be exhaustive.
>
> For instance, select.sgml has only three <indexterm>, and
> the entries for WHERE or JOIN don't even refer to it.
> ISTM that it's on purpose, to keep the index lean, and it works.

Ok.

Patch applies cleanly, doc build ok, works for me.

-- 
Fabien.

  5. Re: Doc patch: add RECURSIVE to bookindex

    Fabien COELHO <coelho@cri.ensmp.fr> — 2018-08-01T11:36:09Z

    Hello Daniel,

> Patch applies cleanly, doc build ok, works for me.

I have added it to the next CF and marked it as ready.

-- 
Fabien.

  6. Re: Doc patch: add RECURSIVE to bookindex

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2018-08-09T20:21:25Z

    On 2018-Aug-01, Fabien COELHO wrote:

> Hello Daniel,
> 
> > Patch applies cleanly, doc build ok, works for me.
> 
> I have added it to the next CF and marked it as ready.

Pushed, thanks.

I applied it to 11 too.  I would have added it even further back, but it
didn't apply cleanly.

How about an index entry for "CSV"?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services