Re: Documentaion fix.

Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>

From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: michael@paquier.xyz
Cc: alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Date: 2018-08-03T07:23:13Z
Lists: pgsql-hackers

Attachments

At Fri, 3 Aug 2018 04:13:56 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20180802191356.GB2247@paquier.xyz>
> On Wed, Aug 01, 2018 at 01:04:37PM +0900, Kyotaro HORIGUCHI wrote:
> > The query and the result with four columns fit the current width.
> 
> Just wondering, what is your reason behind the addition of restart_lsn?
> This part of the documentation focuses on slot creation, so slot_name,
> slot_type and active would be representative enough, no?

The first reason was the example looks having a bit too many
space around only with three other columns.

A more serious reason is that I wanted to show a slot with what
properties is created in the example and I thought that
restart_lsn and temporary are significant. Howerver restart_lsn
is always a part of the pg_replication_slots, we don't have
"temprary" before 10. Addition to that, adding it makes the
SELECT line stick out of the width.

That said, I don't object to reduce the columns. Please find the
attached.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Commits

  1. Fix pg_replication_slot example output