Horton

Re: [PATCH] Add regress test for pg_read_all_stats role

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Alexandra Ryzhevich <aryzhevich@google.com>
Cc: pgsql-hackers@postgresql.org, Vladimir Rusinov <vrusinov@google.com>, Dmitriy Potapov <atomsk@google.com>
Date: 2018-08-02T19:38:11Z
Lists: pgsql-hackers 
On Thu, Aug 02, 2018 at 06:25:14PM +0100, Alexandra Ryzhevich wrote:
> I have noticed that there is no regression tests for default monitoring
> roles such as pg_read_all_stats.

A bug has been recently fixed for that, see 0c8910a0, so having more
coverage would be welcome, now your patch has a couple of problems.
25fff40 is the original commit which has introduced pg_read_all_stats.

Your patch has a couple of problems by the way:
- database creation is costly, those should not be part of the main
regression test suite.
- Any roles created should use "regress_" as prefix.
- You should look also at negative tests which trigger "must be
superuser or a member of pg_read_all_settings", like say a "SHOW
stats_temp_directory" with a non-privileged user.
--
Michael

Commits

  1. Add basic regression tests for default monitoring roles