Re: Documentaion fix.

At Wed, 1 Aug 2018 02:47:32 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20180731174732.GD2878@paquier.xyz>
> On Tue, Jul 31, 2018 at 10:59:14AM -0400, Alvaro Herrera wrote:
> > How about pasting it like this?
> > 
> > alvherre=# select * from pg_replication_slots \gx
> > ─[ RECORD 1 ]───────┬────────────
> > slot_name           │ node_a_slot
> > plugin              │ 
> > slot_type           │ physical
> > datoid              │ 
> > database            │ 
> > temporary           │ f
> > active              │ f
> > active_pid          │ 
> > xmin                │ 
> > catalog_xmin        │ 
> > restart_lsn         │ 
> > confirmed_flush_lsn │ 
> 
> Each time this catalog is changed, this would become incorrect.  My
> suggestion would be to change the query to that and call it a day:
> SELECT slot_name, slot_type, active FROM pg_replication_slots;

Yeah, I'm also concerned about the unstability. I didn't came up
with a list of columns that makes sense at that time but I
rethought on that.

> slot_name           │ required
> plugin              │ <not requried for physical slots>
> slot_type           │ required
> datoid              │ <not requried>
> database            │ <not requried>
> temporary           │ <not requried>
> active              │ required?
> active_pid          │ <not requried>
> xmin                │ <not requried>
> catalog_xmin        │ <not requried>
> restart_lsn         │ better to be shown?
> confirmed_flush_lsn │ <not requried for physical slots>

The query and the result with four columns fit the current width.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center