Horton

Re: Should contrib modules install .h files?

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers@postgresql.org
Date: 2018-07-31T20:17:00Z
Lists: pgsql-hackers 
On 2018-07-31 20:19:49 +0100, Andrew Gierth wrote:
> Final patch just to let cfbot test the windows code for me.
> 
> A review of contrib/ suggested that cube, hstore, isn, ltree and seg
> were the only modules that had useful headers to install, so do those.

I'm a bit surprised that you decided to push to the 11 branch - the
consensus in this thread seem to have gone the other way by my read?
Given that that's the rule, and pushing non-fixes is the exception, I'm
not particularly ok with just ignoring that?

- Andres

Commits

  1. Fix out-of-tree build for transform modules.

  2. Provide for contrib and pgxs modules to install include files.