Re: Segfault logical replication PG 10.4

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Quan Tran <account@itscaro.me>
Cc: pgsql-hackers@lists.postgresql.org, Mai Peng <maily.peng@webedia-group.com>
Date: 2018-07-30T20:33:21Z
Lists: pgsql-hackers
On 2018-Jul-28, Alvaro Herrera wrote:

> Aha, I see, thanks.  Here's a complete fix with included testcase.  In
> an unpatched assert-enabled build, this crashes this
> 
> TRAP: FailedAssertion("!(ActiveSnapshotSet())", File: "/pgsql/source/REL_10_STABLE/src/backend/tcop/postgres.c", Line: 788)
> 
> Will push on Monday.

Pushed after changing the constraint in the test case to be less silly.
Thanks for the report and diagnosis.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Set ActiveSnapshot when logically replaying inserts