Re: Faster str to int conversion (was Table with large number of int columns, very slow COPY FROM)

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alex Tokarev <dwalin@dwalin.ru>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, pgsql-performance@postgresql.org
Date: 2018-07-20T16:45:10Z
Lists: pgsql-hackers, pgsql-performance
Hi,

On 2018-07-20 08:27:34 -0400, Robert Haas wrote:
> On Thu, Jul 19, 2018 at 4:32 PM, Andres Freund <andres@anarazel.de> wrote:
> >> 1. Why the error message changes?  If there's a good reason, it should
> >> be done as a separate commit, or at least well-documented in the
> >> commit message.
> >
> > Because there's a lot of "invalid input syntax for type %s: \"%s\"",
> > error messages, and we shouldn't force translators to have separate
> > version that inlines the first %s.  But you're right, it'd be worthwhile
> > to point that out in the commit message.
> 
> It just seems weird that they're bundled together in one commit like this.

I'll push it separately.

> Nothing else from me...

Thanks for looking!

Greetings,

Andres Freund


Commits

  1. Hand code string to integer conversion for performance.

  2. Deduplicate "invalid input syntax" messages for various types.