Horton

Re: print_path is missing GatherMerge and CustomScan support

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2018-07-19T00:07:22Z
Lists: pgsql-hackers 
On Wed, Jul 18, 2018 at 12:15:25PM +0530, Ashutosh Bapat wrote:
> Yes that's right. Thanks for taking care of it.

Okay, I have pushed a fix for this one as that's wrong and
back-patched to v11.  The coverage of reparameterize_path_by_child is
actually quite poor if you look at the reports:
https://coverage.postgresql.org/src/backend/optimizer/util/pathnode.c.gcov.html

Could it be possible to stress that more?  This way mistakes like this
one could have been avoided from the start.
--
Michael

Commits

  1. Fix print of Path nodes when using OPTIMIZER_DEBUG

  2. Fix re-parameterize of MergeAppendPath