Re: Fix some error handling for read() and errno
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Magnus Hagander <magnus@hagander.net>, Robbie Harwood <rharwood@redhat.com>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, Tom Lane <tgl@sss.pgh.pa.us>, hlinnaka <hlinnaka@iki.fi>
Date: 2018-07-13T23:47:12Z
Lists: pgsql-hackers
On Fri, Jul 13, 2018 at 11:31:31AM -0400, Alvaro Herrera wrote: >> Mr. Robot has been complaining about this patch set, so attached is a >> rebased version. Thinking about it, I would tend to just merge 0001 and >> give up on 0002 as that may not justify future backpatch pain. Thoughts >> are welcome. > > I vote to push both. Thanks! Did you look at the code? The first patch is just some cleanup, while the second could have adjustments? For the second I went with the minimal amount of work, and actually there is no need to make ReadTransientFile() return a status per my study of ReadTwoPhaseFile() in https://postgr.es/m/20180709050309.GM1467@paquier.xyz which must fail when reading the file. So patch 0002 depends on the other 2PC patch. -- Michael
Commits
-
Rework error messages around file handling
- 811b6e36a9e2 12.0 landed