Re: pg_create_logical_replication_slot returns text instead of name

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-07-13T02:22:11Z
Lists: pgsql-hackers
On Fri, Jul 13, 2018 at 11:14:01AM +0900, Masahiko Sawada wrote:
> Hmm, I'm also not sure about the policy of usage of name data type for
> columns that show an object identifier on external servers. There is a
> similar case; we have the pubname in pg_subscritpion as name type
> whereas the subpublications in pg_subscription is text[] type.

Let's not bother then.  In the case of the function you pointed out the
intention behind the code was clear anyway, so that's better now.
--
Michael

Commits

  1. Fix argument of pg_create_logical_replication_slot for slot name