Re: pg_create_logical_replication_slot returns text instead of name

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-07-12T13:18:53Z
Lists: pgsql-hackers
On Thu, Jul 12, 2018 at 07:00:48PM +0900, Masahiko Sawada wrote:
> The documentation[1] says that both pg_create_logical_replication_slot
> and pg_create_physical_replication_slot returns slot_name as a name
> type. But only pg_create_logical_replication_slot returns it as text
> type. I think these should be united as the name type. Attached small
> patch fixes it.
> 
> [1] https://www.postgresql.org/docs/devel/static/functions-admin.html#FUNCTIONS-REPLICATION

That's a small thing, but I agree with you.  As far as I can see slot
names are always mapped with the name type.  I'll push that tomorrow if
there are no objections.
--
Michael

Commits

  1. Fix argument of pg_create_logical_replication_slot for slot name