Horton

Re: Non-reserved replication slots and slot advancing

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, pgsql-hackers@postgresql.org, petr@2ndquadrant.com, simon@2ndQuadrant.com
Date: 2018-07-10T07:59:07Z
Lists: pgsql-hackers

Attachments

On Tue, Jul 10, 2018 at 12:26:30AM -0700, Andres Freund wrote:
> Why is the ReplicationSlotRelease() needed here? Souldn't the error
> handling code do so automatically?

Oh, indeed.  I didn't know that PostgresMain was doing some cleanup
here.  There is a second place where this can be removed, which comes
from the original commit which added the advance function.  An updated
version is attached.  Do you have other comments?
--
Michael

Commits

  1. Block replication slot advance for these not yet reserving WAL