Horton

Re: Simplify final sync in pg_rewind's target folder and add --no-sync

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-10T00:04:10Z
Lists: pgsql-hackers 
On Mon, Jul 09, 2018 at 04:38:11PM +0300, Heikki Linnakangas wrote:
> Looks good to me. I'll mark this as "ready for committer".

Thanks Heikki for the review, I have committed both things after
splitting it into two commits for clarity, and fixing a comment as
fsync_pgdata also initiates a write-back on its first pass when the
option is available.
--
Michael

Commits

  1. Add pg_rewind --no-sync

  2. Simplify logic to sync target directory at the end of pg_rewind