Re: Non-reserved replication slots and slot advancing
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: alvherre@2ndquadrant.com, andres@anarazel.de, pgsql-hackers@postgresql.org, petr@2ndquadrant.com, simon@2ndQuadrant.com
Date: 2018-07-09T06:48:33Z
Lists: pgsql-hackers
Attachments
- slot-advance-unreserved-v3.patch (text/x-diff) patch v3
On Mon, Jul 09, 2018 at 03:13:04PM +0900, Kyotaro HORIGUCHI wrote: > Looking the attached patch, I noticed that both "WAL" and "wal" > are used in similar ERROR messages. Grepping the source tree > showed me that it is always in upper case letters except in the > case it is a part of other words like variable/column/function > names or "walsender". This is the same with the word "lsn". Thanks for the lookup. I see. Indeed, let's fix at the same time the error message close by. xlog.c uses "WAL location (LSN)" for the same thing, so I am sticking with that as per the attached. I'll go commit that if there are no objections. If you see any others which you would like to fix, please feel free to send a patch. -- Michael
Commits
-
Block replication slot advance for these not yet reserving WAL
- 9069eb95f48c 11.0 landed
- 56a714721343 12.0 landed