Horton
Menu

Re: peripatus build failures....

Larry Rosenman <ler@lerctr.org>

View thread
From: Larry Rosenman <ler@lerctr.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-07T00:53:23Z
Lists: pgsql-hackers 
On Fri, Jul 06, 2018 at 07:18:46PM -0400, Tom Lane wrote:
> Larry Rosenman <ler@lerctr.org> writes:
> > On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote:
> >> I do not like the "-Wl,-z,notext" thing at all.  It fails to explain
> >> why things are working OK in v11/HEAD, which makes me think that it's
> >> band-aiding something rather than really fixing it.
> 
> > Following the advice in the error message, the following ALSO fixes it
> > (REL_10_STABLE):
> > +override CFLAGS   := -fPIC
> 
> Yeah, I wondered about whether that wasn't a cleaner answer, but the same
> problem remains: if we need that in src/port/, why don't all the branches
> need it?  It would be unsurprising if we'd gained a requirement for -fPIC
> somewhere along the line, but I don't entirely believe that we lost one.
> So I'd still like to know when this changed.
> 
BROKE:0c62356cc8777961221a643fa77f62e1c7361085
GOOD: f044d71e331d77a0039cec0a11859b5a3c72bc95

f044d71e331d77a0039cec0a11859b5a3c72bc95 fixed it.

Here's the revs I tried:

BROKE:9d4649ca49416111aee2c84b7e4441a0b7aa2fac
GOOD: 3b8f6e75f3c8c6d192621f21624cc8cee04ec3cb
GOOD: 3a5e0a91bb324ad2b2b1a0623a3f2e37772b43fc
GOOD: 8989f52b1b0636969545e6c8f6c813bc563ebcf5
BROKE:0c62356cc8777961221a643fa77f62e1c7361085
GOOD: f044d71e331d77a0039cec0a11859b5a3c72bc95
> 			regards, tom lane

-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640                 E-Mail: ler@lerctr.org
US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Prevent accidental linking of system-supplied copies of libpq.so etc.

  2. Fix partial-build problems introduced by having more generated headers.

  3. Fix the new ARMv8 CRC code for short and unaligned input.

  4. Use ARMv8 CRC instructions where available.

  5. Fix incorrect description of USE_SLICING_BY_8_CRC32C.

  6. Add an assertion that we don't pass NULL to snprintf("%s").

  7. Update copyright for 2018