Re: peripatus build failures....

Larry Rosenman <ler@lerctr.org>

From: Larry Rosenman <ler@lerctr.org>

To: Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2018-07-06T23:15:54Z

Lists: pgsql-hackers

On Fri, Jul 06, 2018 at 06:05:36PM -0500, Larry Rosenman wrote:
> On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote:
> > Larry Rosenman <ler@lerctr.org> writes:
> > > anyone want to look at this, or at least give me a clue on how to add
> > > this to 10 & below?
> > 
> > I do not like the "-Wl,-z,notext" thing at all.  It fails to explain
> > why things are working OK in v11/HEAD, which makes me think that it's
> > band-aiding something rather than really fixing it.
> > 
> > Perhaps you could spend a bit of time with git bisect and find out
> > which commit un-broke things?  That should help us narrow down the
> > true explanation.
> > 
> > 			regards, tom lane
> 
> Following the advice in the error message, the following ALSO fixes it
> (REL_10_STABLE):
> 
> borg.lerctr.org /home/ler/Git/postgresql/src/port $ git diff
> diff --git a/src/port/Makefile b/src/port/Makefile
> index 81f01b25bb..9ef00b3d54 100644
> --- a/src/port/Makefile
> +++ b/src/port/Makefile
> @@ -28,6 +28,7 @@ top_builddir = ../..
>  include $(top_builddir)/src/Makefile.global
> 
>  override CPPFLAGS := -I$(top_builddir)/src/port -DFRONTEND $(CPPFLAGS)
> +override CFLAGS   := -fPIC
>  LIBS += $(PTHREAD_LIBS)
> 
>  OBJS = $(LIBOBJS) $(PG_CRC32C_OBJS) chklocale.o erand48.o inet_net_ntop.o \
> borg.lerctr.org /home/ler/Git/postgresql/src/port $
> 
> Is that more acceptable?

Err, add a $(CFLAGS) to the end of the added line.


> -- 
> Larry Rosenman                     http://www.lerctr.org/~ler
> Phone: +1 214-642-9640                 E-Mail: ler@lerctr.org
> US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106



-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640                 E-Mail: ler@lerctr.org
US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Prevent accidental linking of system-supplied copies of libpq.so etc.
- f6f75539d247 9.3.24 landed
- dd4e836748ce 9.4.19 landed
- ccc286da1d35 9.6.10 landed
- c74f48a4ec54 10.5 landed
- 6532ca57ad32 9.5.14 landed
- dddfc4cb2edc 11.0 cited
Fix partial-build problems introduced by having more generated headers.
- 3b8f6e75f3c8 11.0 cited
Fix the new ARMv8 CRC code for short and unaligned input.
- 3a5e0a91bb32 11.0 cited
Use ARMv8 CRC instructions where available.
- f044d71e331d 11.0 cited
Fix incorrect description of USE_SLICING_BY_8_CRC32C.
- 8989f52b1b06 11.0 cited
Add an assertion that we don't pass NULL to snprintf("%s").
- 0c62356cc877 11.0 cited