Re: peripatus build failures....

Larry Rosenman <ler@lerctr.org>

From: Larry Rosenman <ler@lerctr.org>
To: Thomas Munro <thomas.munro@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-06T22:19:59Z
Lists: pgsql-hackers
On Thu, Jul 05, 2018 at 07:47:39AM -0500, Larry Rosenman wrote:
> On Wed, Jul 04, 2018 at 08:37:40PM -0500, Larry Rosenman wrote:
> > On Wed, Jul 04, 2018 at 08:19:48PM -0500, Larry Rosenman wrote:
> > > On Thu, Jul 05, 2018 at 12:56:49PM +1200, Thomas Munro wrote:
> > > > On Thu, Jul 5, 2018 at 12:35 PM, Larry Rosenman <ler@lerctr.org> wrote:
> > > > > I agree.  Is there an easy way I can add this work around to peripatus'
> > > > > source tree:
> > > > >
> > > > > It may be that adding "LDFLAGS+= -Wl,-z,notext" (and removing LLD_UNSAFE) will let the port build with lld.
> > > > 
> > > > Maybe something like this at the end of your build-farm.conf?
> > > > 
> > > > if ($branch =~ /^REL(9|_10)/)
> > > > {
> > > >     $conf{config_env}->{"LDFLAGS"} = "...something something...";
> > > > }
> > > > 
> > > 
> > > Good news.  I ran a quick build test on my checked out FreeBSD ports
> > > tree and with Ed Maste's suggestion, it builds. 
> > > 
> > > Ed's suggestion:
> > > remove LLD_UNSAFE, and add to the LDFLAGS+= line in the port
> > > -Wl,-z,notext.
> > > 
> > > So, that is indeed a fix for us.  My question is:
> > > how to add this LDFLAG for FreeBSD >= 12 and PostgreSQL <= 11's configure et al
> > > 
> > > I'm more than willing to try and generate a patch, but would like some
> > > guidance.  I'm also willing to give access to my box.
> > > 
> > > 
> > 
> > I also filed FreeBSD pr
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229523 to make the
> > change in the FreeBSD port.
> > 
> 
> I suspect HEAD and REL_11 are ok due to changes in the pgport source.
> (Someone with better git foo would have to check that).
> 
> 
anyone want to look at this, or at least give me a clue on how to add
this to 10 & below?


-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640                 E-Mail: ler@lerctr.org
US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Prevent accidental linking of system-supplied copies of libpq.so etc.

  2. Fix partial-build problems introduced by having more generated headers.

  3. Fix the new ARMv8 CRC code for short and unaligned input.

  4. Use ARMv8 CRC instructions where available.

  5. Fix incorrect description of USE_SLICING_BY_8_CRC32C.

  6. Add an assertion that we don't pass NULL to snprintf("%s").

  7. Update copyright for 2018