Re: Non-reserved replication slots and slot advancing

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: alvherre@2ndquadrant.com, andres@anarazel.de, pgsql-hackers@postgresql.org, petr@2ndquadrant.com, simon@2ndQuadrant.com
Date: 2018-07-06T05:26:42Z
Lists: pgsql-hackers
On Fri, Jul 06, 2018 at 01:07:47PM +0900, Kyotaro HORIGUCHI wrote:
> Form the reasons above, I'd like to vote +1 for just ERRORing
> in the case.

Thanks for the lookup.  Do you have a good idea for the error message to
provide to users in this case?  I would tend to think that "cannot move
slot which has never been reserved" or "cannot move slot which has never
been used", particularly the first one, are fine enough, but I am not
stopped at one single idea in particular either.
--
Michael

Commits

  1. Block replication slot advance for these not yet reserving WAL