Horton

Re: Should contrib modules install .h files?

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Date: 2018-07-06T01:45:07Z
Lists: pgsql-hackers 
On Wed, Jul 04, 2018 at 05:00:56PM -0400, Tom Lane wrote:
> Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
>> This installs to $(includedir_server)/$(MODULEDIR)/$MODULE/file.h
>> (e.g. include/server/extension/hstore/hstore.h for an actual example),
>> and errors if HEADERS_xxx is defined for anything that's not a module
>> listed in MODULES or MODULE_big.
> 
> I've not studied this patch in any great detail, but the basic plan seems
> sane.  However, don't we also need to teach the MSVC build system about
> this?

+1.  I have not looked at this patch in details myself, but the concept
looks good.
--
Michael

Commits

  1. Fix out-of-tree build for transform modules.

  2. Provide for contrib and pgxs modules to install include files.