Horton
Menu

Re: peripatus build failures....

Larry Rosenman <ler@lerctr.org>

View thread
From: Larry Rosenman <ler@lerctr.org>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-05T00:35:28Z
Lists: pgsql-hackers 
On Thu, Jul 05, 2018 at 12:30:37PM +1200, Thomas Munro wrote:
> On Thu, Jul 5, 2018 at 11:43 AM, Larry Rosenman <ler@lerctr.org> wrote:
> > I noticed my buildfarm member peripatus hadn't been building due to me
> > missing a perl library.  After I fixed that I get failures on:
> >
> > Buildfarm member peripatus failed on REL9_3_STABLE stage Make
> > Buildfarm member peripatus failed on REL9_4_STABLE stage Make
> > Buildfarm member peripatus failed on REL9_5_STABLE stage Make
> > Buildfarm member peripatus failed on REL9_6_STABLE stage Make
> > Buildfarm member peripatus failed on REL_10_STABLE stage Make
> >
> > HEAD and REL_11_STABLE build fine.
> >
> > These all fail on relocation issues in pgport(strcase*) and possibly
> > others.
> >
> > This is FreeBSD HEAD as of today, clang 6.0.1, lld as the linker.
> >
> > Can someone take a look at these?
> > I've tried making sure all the cache's are clear, etc, same results.
> 
> Seems to have something to do with the recent linker toolchain changes
> in FreeBSD.  I don't actually understand what's going on here or why
> it doesn't affect REL_11_STABLE and HEAD, but this seems to be some
> kind of explanation + workaround (as used by the ports):
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219758
> https://svnweb.freebsd.org/ports?view=revision&revision=456635
> 
I agree.  Is there an easy way I can add this work around to peripatus'
source tree:

It may be that adding "LDFLAGS+= -Wl,-z,notext" (and removing LLD_UNSAFE) will let the port build with lld.

Thanks, Thomas.

-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 214-642-9640                 E-Mail: ler@lerctr.org
US Mail: 5708 Sabbia Drive, Round Rock, TX 78665-2106

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Prevent accidental linking of system-supplied copies of libpq.so etc.

  2. Fix partial-build problems introduced by having more generated headers.

  3. Fix the new ARMv8 CRC code for short and unaligned input.

  4. Use ARMv8 CRC instructions where available.

  5. Fix incorrect description of USE_SLICING_BY_8_CRC32C.

  6. Add an assertion that we don't pass NULL to snprintf("%s").

  7. Update copyright for 2018