Re: pgsql: Clarify use of temporary tables within partition trees

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-03T06:11:19Z
Lists: pgsql-hackers
On Tue, Jul 03, 2018 at 06:00:46PM +1200, David Rowley wrote:
> Thanks for fixing it up. It looks fine apart from "Temporation" should
> be "Temporary".

Of course, thanks.

> I think it should be backpatched to v11 and v10. Your original commit
> went there too. I don't see any reason to do any different here than
> what you did with the original commit.

expand_partitioned_rtentry is new as of v11.  Or you mean to tweak
expand_inherited_rtentry() perhaps?  I am not sure that it is worth it
as the code has already diverged between 10 and 11.
--
Michael

Commits

  1. Remove dead code for temporary relations in partition planning

  2. Clarify use of temporary tables within partition trees

  3. Expand partitioned table RTEs level by level, without flattening.