Re: pgsql: Clarify use of temporary tables within partition trees

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es

From: Michael Paquier <michael@paquier.xyz>

To: David Rowley <david.rowley@2ndquadrant.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Postgres hackers <pgsql-hackers@postgresql.org>

Date: 2018-07-03T04:55:02Z

Lists: pgsql-hackers

Attachments

remove_dead_code_from_expand_partitioned_rtentry_v3.patch (text/x-diff) patch v3

On Tue, Jul 03, 2018 at 12:59:33PM +1200, David Rowley wrote:
> On 3 July 2018 at 10:16, Michael Paquier <michael@paquier.xyz> wrote:
>> On Mon, Jul 02, 2018 at 02:07:37PM -0400, Robert Haas wrote:
>>> I'd rather keep an elog(ERROR) than completely remove the check.
>>
>> +1.
>
> Attached

Okay, the patch looks logically correct to me, I just tweaked the
comments as per the attached.  I would also back-patch that down to v11
to keep the code consistent with HEAD..  What do you think?
--
Michael

Commits

Remove dead code for temporary relations in partition planning
- 5fca035903a2 11.0 landed
- fc057b2b8fc3 12.0 landed
Clarify use of temporary tables within partition trees
- 5862174ec78a 10.5 cited
Expand partitioned table RTEs level by level, without flattening.
- 0a480502b092 11.0 cited