Re: pgsql: Clarify use of temporary tables within partition trees

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>, pgsql-committers@lists.postgresql.org
Date: 2018-07-02T22:16:50Z
Lists: pgsql-hackers
On Mon, Jul 02, 2018 at 02:07:37PM -0400, Robert Haas wrote:
> I'd rather keep an elog(ERROR) than completely remove the check.

+1.

> Also, for the record, I think the subject line of Michael's commit
> message was pretty unclear about what it was actually doing.

How would you formulate it?  Perhaps the error message did not emphasize
enough on the fast that it actually blocked a behavior, say "Block mix
of temporary and permanent relations in partition trees" or such?
--
Michael

Commits

  1. Remove dead code for temporary relations in partition planning

  2. Clarify use of temporary tables within partition trees

  3. Expand partitioned table RTEs level by level, without flattening.