Horton

Thread

Commits

  1. Correct function name in comment of logical decoding code

  1. Comment refers to non existent function IncreaseRestartDecodingForSlot

    Dave Cramer <davecramer@gmail.com> — 2018-06-29T18:55:02Z

    While trying to figure out this code I found

https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/replication/logical/logical.c;h=61588d626f608006196c769ad9807f1d3ac592e9;hb=HEAD#l913

What function should it be referring to ?

Thanks,

Dave Cramer

  2. Re: Comment refers to non existent function IncreaseRestartDecodingForSlot

    Euler Taveira <euler@timbira.com.br> — 2018-06-29T20:34:21Z

    2018-06-29 15:55 GMT-03:00 Dave Cramer <davecramer@gmail.com>:
> While trying to figure out this code I found
>
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/replication/logical/logical.c;h=61588d626f608006196c769ad9807f1d3ac592e9;hb=HEAD#l913
>
> What function should it be referring to ?
>
LogicalIncreaseXminForSlot (it is a few lines above). It has been like
that since logical decoding was introduced. The trivial patch fixes
it.


-- 
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

  3. Re: Comment refers to non existent function IncreaseRestartDecodingForSlot

    Michael Paquier <michael@paquier.xyz> — 2018-07-02T04:32:45Z

    On Fri, Jun 29, 2018 at 05:34:21PM -0300, Euler Taveira wrote:
> LogicalIncreaseXminForSlot (it is a few lines above). It has been like
> that since logical decoding was introduced. The trivial patch fixes
> it.

That looks right to me.  Pushed.
--
Michael