Re: ALTER TABLE on system catalogs

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-06-27T23:10:28Z
Lists: pgsql-hackers
On Wed, Jun 27, 2018 at 01:37:33PM -0700, Andres Freund wrote:
> On 2018-06-27 22:31:30 +0200, Peter Eisentraut wrote:
>> I propose that we instead silently ignore attempts to add TOAST tables
>> to shared and system catalogs after bootstrapping.
> 
> That seems like an extremely bad idea to me.  I'd rather go ahead and
> just add the necessary toast tables than silently violate preconditions
> that code assumes are fulfilled.

Agreed.  Joe Conway was working on a patch to do exactly that.  I was
personally looking for the possibility of having one with pg_authid in
v12 :)
--
Michael

Commits

  1. Ignore attempts to add TOAST table to shared or catalog tables