Horton

Re: Performance regression with PostgreSQL 11 and partitioning

Alvaro Herrera <alvherre@2ndquadrant.com>

View thread View on postgr.es
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <david.rowley@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Amit Langote <amitlangote09@gmail.com>, Thomas Reiss <thomas.reiss@dalibo.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-06-27T19:43:46Z
Lists: pgsql-hackers 
On 2018-Jun-27, Amit Langote wrote:

> I noticed that there is a typo in a comment, fixed as follows in the
> attached patch.
> 
>      /*
> -     * append_rel_list is the same length as the above arrays, and holds
> +     * append_rel_array is the same length as the above arrays, and holds
>       * pointers to the corresponding AppendRelInfo entry indexed by
>       * child_relid, or NULL if none.  The array itself is not allocated if
>       * append_rel_list is empty.

Yikes.  I looked for that kind of mistake *specifically* :-(
Thanks, pushed.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix typo in comment

  2. Allow direct lookups of AppendRelInfo by child relid

  3. Teach adjust_appendrel_attrs(_multilevel) to do multiple translations.