Re: Small fixes about backup history file in doc and pg_standby
Yugo Nagata <nagata@sraoss.co.jp>
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-06-27T08:42:07Z
Lists: pgsql-hackers
On Wed, 27 Jun 2018 00:58:18 +0900 Fujii Masao <masao.fujii@gmail.com> wrote: > On Tue, Jun 26, 2018 at 5:47 PM, Yugo Nagata <nagata@sraoss.co.jp> wrote: > > Hi, > > > > While looking into the backup and recovery code, I found small documentation bugs. > > The documatation says that the backup history files can be requested for recovery, > > but it's not used by the system and not requested anymore since PG 9.0 > > (commit 06f82b29616cd9effcaefd99c6b6e2e80697482f) and never be requested. > > > > Attached patch (doc_backup_history_file.patch) corrects the description about this. > > Pushed. Thanks! Thanks! > > > In addition, the current pg_standby still can handle a backup history file that are > > never requested. It is harmless but unnecessary code. Another attached patch > > (pg_standby.patch) removes this part of code. > > Since this is not bug fix, let's discuss this in 12dev cycle. Certainly. Regards, > > Regards, > > -- > Fujii Masao > -- Yugo Nagata <nagata@sraoss.co.jp>
Commits
-
Fix documentation bug related to backup history file.
- 833397e73e2e 9.3.24 landed
- 4765ac057073 9.4.19 landed
- ef2deca1b77e 9.5.14 landed
- d06d92cd2d5e 9.6.10 landed
- 09879f753635 10.5 landed
- bbbbc2f8f3f7 11.0 landed
-
Write an end-of-backup WAL record at pg_stop_backup(), and wait for it at
- 06f82b29616c 9.0.0 cited