Re: wrong query result with jit_above_cost= 0
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>, Rushabh Lathia <rushabh.lathia@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-06-26T20:56:43Z
Lists: pgsql-hackers
On 2018-06-26 21:55:07 +0100, Andrew Gierth wrote: > >>>>> "Dmitry" == Dmitry Dolgov <9erthalion6@gmail.com> writes: > > Dmitry> Yep, my bad, forgot to turn it on. Now I see what's the > Dmitry> problem, one of the null fields is screwed up, will try to > Dmitry> figure out why is that. > > The handling of nulls in grouping set results is a bit icky, see > prepare_projection_slot in nodeAgg.c. The comment there lists a number > of assumptions which may or may not hold true under JIT which might give > a starting point to look for problems. (Unfortunately I'm not currently > in a position to test on a JIT build) I probably just screwed up a bit of code generation. I can't see any of the more fundamental assumptions being changed by the way JITing is done. Greetings, Andres Freund
Commits
-
Reset context at the tail end of JITed EEOP_AGG_PLAIN_TRANS.
- 0171ad9308ac 11.0 landed
- 1307bc3d45c1 12.0 landed
-
Fix JITed EEOP_AGG_INIT_TRANS, which missed some state.
- a9a0a4d3f88b 11.0 landed
- 6b4d860311e9 12.0 landed