Horton

Re: Incorrect fsync handling in pg_basebackup's tar_finish

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>, Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-06-25T13:17:29Z
Lists: pgsql-hackers

Attachments

On Mon, Jun 25, 2018 at 05:48:54PM +0530, Kuntal Ghosh wrote:
> In the same note, in tar_close(), we fsync on close. We're not
> checking the status of fsync there. Should we introduce the same check
> there as well?

Yes, there is a second one.  I just looked at walmethods.c and I did not
spot any other issues.  What do you think about the updated version
attached?
--
Michael

Commits

  1. Correct handling of fsync failures with tar mode of walmethods.c