Re: Adding tests for inheritance trees with temporary tables

On Tue, Jun 19, 2018 at 01:04:43PM +0530, Ashutosh Bapat wrote:
> Thanks. Some review comments here.

Thanks for the review!
 
> +create table inh_perm_parent (a1 int);
> +create temp table inh_temp_parent (a1 int);
> +create temp table inh_temp_child (a1 int) inherits (inh_perm_parent); -- ok
> +NOTICE:  merging column "a1" with inherited definition
> 
> You could actually avoid this notice by changing create table statement like
> create temp table inh_temp_child () inherits (inh_perm_parent);

Okay, fixed.

> select tabloid::regclass will also print the name of the table where
> the row resides. That will be useful to check where the rows come from
> and also to test the inheritance children.

Good point, I have added those.  Except that you meant
tableoid::regclass.
--
Michael